Running action such as `dsq` changes last visual selection marks

smjonas commented 2 years ago

Checklist

[X] Have you updated the plugin to the latest version on main branch?
[X] Have you checked the Breaking Changes issue?
[X] Have you read through :h nvim-surround to see if there might be any relevant information there?

To reproduce

Select a range of text in a buffer:
Now run a nvim-surround command, e.g. dsq
Run gv to reselect the last visually selected lines.

Expected behavior

The lines selected in step 1 should be visually selected.

Actual behavior

The position from the first quote to the last one (here: "packer.nvim") is selected.

Additional context

This behavior causes some issues with a plugin of mine so it would be great if the '< and '> marks were restored after a command is run. I'll try to make a PR :)

kylechui commented 2 years ago

Apologies for being inactive these last few weeks; school + life is one hell of a combo. I'll try to make time to review your PRs sometime this upcoming week.

smjonas commented 2 years ago

Thanks for taking the time to merge this!

kylechui commented 2 years ago

Thanks for taking the time to write the PR! It really helps out a lot, even if it's small. :sparkling_heart:

kylechui / nvim-surround