Setting any option in `keymaps` to an empty string yields error

luiz00martins commented 1 year ago

Checklist

[X] Have you tried updating the plugin to the latest version?
[X] Have you checked the Breaking Changes issue?
[X] Have you read through :h nvim-surround to see if there might be any relevant information there?

Neovim Version

NVIM v0.9.0-dev-849+g7880eeb2e

Plugin Version

Tagged (Stable)

Minimal Configuration

require('nvim-surround').setup {
    keymaps = {
        insert = "",
        insert_line = "",
        normal = "s",
        normal_cur = "ss",
        normal_line = "yS",
        normal_cur_line = "ySS",
        visual = "s",
        visual_line = "S",
        delete = "ds",
        change = "cs",
    },
}

Sample Buffer

none

Keystroke Sequence

none

Expected behavior

The mapping would be ignored (not created).

Actual behavior

Error:

vim/keymap.lua:0: Invalid (empty) LHS

# stacktrace:
  - vim/keymap.lua:0 _in_ **set**
  - .config/nvim/init/plugins_portable.lua:1330 _in_ **config**
  - lua:40

Additional context

No response

kylechui commented 1 year ago

They should be set to false to disable them.

luiz00martins commented 1 year ago

Yep, seems to work. Thank you.

Is this not still a bug though? If not, you can close.