search

kylechui / nvim-surround

Add/change/delete surrounding delimiter pairs with ease. Written with :heart: in Lua.
MIT License
2.92k stars 60 forks source link

test: test run locally #246

Closed IlyasYOY closed 11 months ago

IlyasYOY commented 1 year ago

Hello! Thank you for this plugin! It's awesome!

I saw your comment here. So, I decided to give it a try.

I managed to run tests locally. They didn't hang.

But some of them were failing: 

~/Projects/other/nvim-surrond-fork on  main ⌚ 21:47:42
$ make | grep -e "Success:" -e "Failed :"
Starting...Success:     0
Failed :        2
Success:        0
Failed :        3
Success:        0
Failed :        5
Success:        0
Failed :        8
Success:        1
Failed :        6
Success:        3
Failed :        16
Success:        9
Failed :        0

PS. I'm sure that this is not the solution, but hope this may help you find the solution.

IlyasYOY commented 1 year ago

In my plugins I look up to @folke's solutions. Good example is shown here.

kylechui commented 1 year ago

That's very interesting, maybe something's wrong with my configuration. I'll take a look later, thanks for the pointer!

kylechui commented 1 year ago

I checked out your branch and it also doesn't hang anymore, although now it is failing a bunch of test cases, which is less than ideal (and also strange, given that the core plugin doesn't utilize plenary at all). My tests work if I run them file-by-file, and they used to work on an older version of Neovim; I really don't know what happened to it. I do appreciate your work; hopefully I can understand your commit better at some point and isolate what the issue is.

IlyasYOY commented 1 year ago

I did fix the issue. The answer is always simple.

I forgot to add: require("nvim-surround").setup().

~/Projects/other/nvim-surrond-fork on  main! ⌚ 8:37:29
$ make | grep -e "Success:" -e "Failed :"
Starting...Success:     3
Failed :        0
Success:        2
Failed :        0
Success:        7
Failed :        0
Success:        8
Failed :        0
Success:        5
Failed :        0
Success:        19
Failed :        0
Success:        9
Failed :        0
kylechui commented 11 months ago

I'm not entirely sure what happened, but I updated plenary and it seems to be working for me again(?) Thanks for taking the time to submit the PR nonetheless (and sorry for the radio silence)!