Removing CommonCrypto to fix builds in Xcode 10 beta

kylef / JSONWebToken.swift

Swift implementation of JSON Web Token (JWT).

http://jwt.io

BSD 2-Clause "Simplified" License

763 stars 226 forks source link

Removing CommonCrypto to fix builds in Xcode 10 beta #108

Open jondwillis opened 6 years ago

jondwillis commented 6 years ago

See: https://github.com/kylef/JSONWebToken.swift/issues/102

kylef commented 6 years ago

@jondwillis Can you rework this PR so it works on the current version of Xcode too?

jonblatho commented 6 years ago

I have a fix in #112 for this issue that works across both Swift 4.1.x and Swift 4.2. Earlier versions of Swift aren’t supported because #if canImport(ModuleName) was added in Swift 4.1.

I tried some other ways to get it working on earlier Swift versions and could not get them working reliably, but a better way may exist and I frankly didn’t invest too much time into it. In any case, feel free to borrow the fix if needed.

Coeur commented 5 years ago

@kylef According to an Apple news from September 2018, this month of March 2019 will see Xcode 10 being mandatory for publishing iOS apps. And Xcode 10 supports Swift 4.x and #if canImport(), so there is really no need to keep support for older versions of Xcode.