Closed jonblatho closed 4 years ago
Swift 4 deprecates deallocate(capacity:)
, but CI builds are failing because deallocate
is missing an argument for capacity.
Interesting…are the CI builds really using Swift 4?
Update: After tinkering with the Travis config, builds and tests are passing on all macOS configurations (using Xcode 9.4/Swift 4.1.2) and swift build
passes on Trusty but swift test
does not. Investigating…
Update 2: Travis builds are passing again. I’ll update the configuration such that it should do the same tests as before, adding back swift test
on Ubuntu.
@jonblatho I tried out your changes, but when running carthage update --platform ios
with Xcode 10 beta 5 I get this:
*** Skipped building JSONWebToken.swift due to the error:
Dependency "JSONWebToken.swift" has no shared framework schemes for any of the platforms: iOS
If you believe this to be an error, please file an issue with the maintainers at https://github.com/jonblatho/JSONWebToken.swift/issues/new
@jakekrog I unfortunately don’t really have any experience with Carthage at all, let alone enough to handle issues with it. I’m sorry!
@jonblatho It was actually my mistake, I didn't realize that the project file had been removed in the master branch.
Is this going to be reviewed/merged any time soon?
Thanks @jonblatho!
Summary of what’s changed:
ClaimSet
type will no longer need to be given explicitlydeallocate(capacity:)
deprecationvalidateExpiary(leeway:)
tovalidateExpiry(leeway:)
— the old misspelled method is still available but deprecatedClaimSet
instead ofPayload
With all that said, this PR alone would probably make for a decent 3.0 release given the code-breaking change at the top of the list. Perhaps also consider #99/#106; it’s a quick-and-easy change that people seem to want.