kylef / JSONWebToken.swift

Swift implementation of JSON Web Token (JWT).
http://jwt.io
BSD 2-Clause "Simplified" License
763 stars 226 forks source link

Remove deprecated encode/decode methods, fix warnings and other… #112

Closed jonblatho closed 4 years ago

jonblatho commented 6 years ago

Summary of what’s changed:

With all that said, this PR alone would probably make for a decent 3.0 release given the code-breaking change at the top of the list. Perhaps also consider #99/#106; it’s a quick-and-easy change that people seem to want.

jonblatho commented 6 years ago

Swift 4 deprecates deallocate(capacity:), but CI builds are failing because deallocate is missing an argument for capacity.

Interesting…are the CI builds really using Swift 4?

Update: After tinkering with the Travis config, builds and tests are passing on all macOS configurations (using Xcode 9.4/Swift 4.1.2) and swift build passes on Trusty but swift test does not. Investigating…

Update 2: Travis builds are passing again. I’ll update the configuration such that it should do the same tests as before, adding back swift test on Ubuntu.

jakekrog commented 6 years ago

@jonblatho I tried out your changes, but when running carthage update --platform ios with Xcode 10 beta 5 I get this:

*** Skipped building JSONWebToken.swift due to the error:
Dependency "JSONWebToken.swift" has no shared framework schemes for any of the platforms: iOS

If you believe this to be an error, please file an issue with the maintainers at https://github.com/jonblatho/JSONWebToken.swift/issues/new
jonblatho commented 6 years ago

@jakekrog I unfortunately don’t really have any experience with Carthage at all, let alone enough to handle issues with it. I’m sorry!

jakekrog commented 6 years ago

@jonblatho It was actually my mistake, I didn't realize that the project file had been removed in the master branch.

plflanagan commented 5 years ago

Is this going to be reviewed/merged any time soon?

kylef commented 4 years ago

Thanks @jonblatho!