search

kylef / JSONWebToken.swift

Swift implementation of JSON Web Token (JWT).
http://jwt.io
BSD 2-Clause "Simplified" License
762 stars 226 forks source link

Add Carthage Support #21

Closed tternes closed 8 years ago

tternes commented 8 years ago

This change set provides Carthage support for the library, which would resolve #17.

I've attempted to follow the example of AlamofireImage for how to best satisfy dependencies while not requiring integrators to use a particular dependency management system. To accomplish this goal, I've removed internal use of Pods within JSONWebToken, and instead satisfy the CryptoSwift dependency with a submodule. I've added a Cartfile that handles the dependency chain for Carthage users, and attempted to verify CocoaPods support with a local spec. I've also updated the Travis tests and run them against my fork to make sure those continue working.

As a Carthage user, I'm most concerned about having possibly broken CocoaPods, so feedback in that area would be greatly appreciated.

As a look ahead, I'm also planning to submit changes to add support for an iOS framework target, as well as code changes to support custom header values and signing key formats. I'll also submit a follow-up PR with changes for the README.

tternes commented 8 years ago

Any chance you'll be able to review this in the next few days, @kylef? I have a couple other changes queued up that I've held until this merges.

Thanks!

tternes commented 8 years ago

@kylef I get the following error when I run pod lib lint --no-clean --verbose locally:

** BUILD SUCCEEDED **

 -> JSONWebToken (1.4.2)
    - WARN  | url: The URL (http://twitter.com/kylefuller) is not reachable.

I've taken care of the other comments.

kylef commented 8 years ago

Okay, just two remaining comments. I've fixed the issue with the podspec in 6df50e2, so rebasing on-top of master should solve this. Would you be able to address them and then squash these commits?

I have one concern, that the Xcode project only has an OS X Target. From what I understand, that means Carthage will only be able to integrate this library into OS X and it won't work for iOS, tvOS and watchOS users. Is this a problem for you?

tternes commented 8 years ago

I have one concern, that the Xcode project only has an OS X Target.

I have another PR ready for iOS / tvOS targets that should take care of that.

tternes commented 8 years ago

@kylef The pod lint step passes for me locally, but it looks like Travis has an issue with it. Any chance you can give me some guidance on that, since I'm not as familiar with what pods might be upset about?

Thanks so much for your help with this.