search

kylef / JSONWebToken.swift

Swift implementation of JSON Web Token (JWT).
http://jwt.io
BSD 2-Clause "Simplified" License
763 stars 226 forks source link

CryptoSwift version updated #84

Closed ivopintodasilva closed 4 years ago

ivopintodasilva commented 6 years ago

This fixed the Carthage build for Xcode 9.

kylef commented 6 years ago

@IvoPintodaSilva You change has no effect on Xcode. The Package.swift file is for the Swift Package Manager and is not related to Carthage. This code change is in the branch of the dependencies for non Apple platforms. Any Xcode project generated by swift will be using the other branch of dependencies. Am I missing something? Did you test your change?

#if os(macOS) || os(iOS) || os(watchOS) || os(tvOS)
...
#else
....Package(url: "https://github.com/krzyzanowskim/CryptoSwift.git", majorVersion: 0, minor: 7)
#endif
krzyzanowskim commented 6 years ago

or even more strict

Package(url: "https://github.com/krzyzanowskim/CryptoSwift.git", "0.7.2")
jonblatho commented 6 years ago

CryptoSwift is now at version 0.8.0 and this package, which supports Swift 4 only on the master branch, continues to refer to version 0.6.9, which was released in April, before Swift 4.

The fact that the pull requester’s comment was less than relevant to the purpose of this change doesn’t change the fact that this package has not compiled on Linux for months because of the outdated CryptoSwift dependency and the version bump remains very necessary.