search

kylef / heroku-buildpack-swift

Heroku build pack for Swift
BSD 3-Clause "New" or "Revised" License
508 stars 0 forks source link

Deploys failing on latest update #9

Closed loganwright closed 8 years ago

loganwright commented 8 years ago

Hi Kyle,

First, thanks so much for the buildpack! It has made getting setup on Heroku a breeze and been very awesome to work with.

I'm worried that commit b6d6c6 might have introduced a bug. Or perhaps there's some new requirements I'm not fulfilling.

Here's an example error output:

-----> Copying dynamic libraries
cp: cannot stat ‘/tmp/build_a7bfb1498876ce5899a7c598f604aa16/.build/release/*.so’: No such file or directory
 !     Push rejected, failed to compile Swift app

And a link to the original issue that was brought to my attention on my repo here.

Let me know if I can help

Thanks again!

briancroom commented 8 years ago

Hi @LoganWright, I believe the culprit commit+line here is actually https://github.com/kylef/heroku-buildpack-swift/commit/5a694fda377fd9ff807f61c8666a369a70bab2d6#diff-c7b43338c09c3c9afd420fd8b6bb5198R63 as this command actually fails if the glob pattern does not match any files.

When I opened a PR for the Cloud Foundry fork of this buildpack to merge in recent upstream improvements, I adjusted that command to be more robust, like this: https://github.com/cloudfoundry-community/swift-buildpack/pull/13/files#diff-c7b43338c09c3c9afd420fd8b6bb5198R75

I would suggest trying that same change here and opening a PR if it resolves the issue for you!

loganwright commented 8 years ago

@briancroom Your suggestions worked on my fork, and I put the PR back into this repo. Thank you! Let's see what Kyle has to say about it.