search

kylefarris / clamscan

A robust ClamAV virus scanning library supporting scanning files, directories, and streams with local sockets, local/remote TCP, and local clamscan/clamdscan binaries (with failover).
MIT License
230 stars 68 forks source link

Tests for connect over TLS were bypassed due to the unix socket path being populated #107

Closed carboneater closed 5 months ago

carboneater commented 1 year ago

So I wanted to try to reproduce the CI errors regarding ClamAV sometimes returning an empty array. I never managed to reproduce it locally.

However, I realized the TLS tests would pass, even when stunnel was stopped... Overriding the default test values to force the right code branch uncovered two minor bugs... And started a whole new round of fighting with GitHub Actions...

The two 30s timers in the pipeline were replaced with pauses until services are detected to be ready. Sadly, even this did not fix the flakiness from the good files array test...

kylefarris commented 5 months ago

I've added the pertinent changes from this PR to Master. Thanks for the contribution @carboneater . I'll get the dependencies updated before the next release.