search

kylefarris / node-querybuilder

Node QueryBuilder Adapter for Node.js (tags: nodejs, node, mysql, active record, activerecord, querybuilder, query builder)
49 stars 19 forks source link

issue #8 Fix for functions in like clauses #15

Closed louisl closed 6 years ago

louisl commented 6 years ago

Checks 'AS' exists, if it doesn't skip dealing with it and return the raw item.

kylefarris commented 6 years ago

Louis, thanks for the PR. It seems its causing a few of the tests to fail, though. Some of them are failing simply because they are testing string equivalency and the test is looking for as where the script is now writing the SQL with AS (uppercase). I have no problem with it being AS (of course) but those tests will need to be updated.

There is, however, another test that's failing that isn't related to as vs AS. I'll need you to look into that before this PR can be merged.

Thanks again!