search

kylefarris / node-querybuilder

Node QueryBuilder Adapter for Node.js (tags: nodejs, node, mysql, active record, activerecord, querybuilder, query builder)
49 stars 19 forks source link

Fixes #23: update_batch not working #24

Closed arifjaunpur closed 6 years ago

arifjaunpur commented 6 years ago

23

kylefarris commented 6 years ago

Thanks Arif. These changes look good. Would you please add a new test to /test/mysql/tests-update_batch.js to test actually providing a "where" param? Doesn't look like I ever wrote a test for that for some reason.

Thanks again!

kylefarris commented 6 years ago

@arifjaunpur The code has changed too much in v2 for me to merge this in directly, but, I've used your code to fix the bug in the new version and added a test. Thanks for the PR!