AWS CloudFront signed URLs breaking Video tag generation

ocasta commented 8 years ago

We have our assets stored on S3 and served through Cloudfront. As long as we don't delete local files then everything seems to work OK. Requesting a page generates a video tag that looks like this: `

            </video>`

We have now added a plugin that generates AWS Signed URLs for media assets (it's a filter on wp_get_attachment_url) and the video tag is now wrong and the page now contains the following

No sources are being generated. The Signed URL for the video has the same format and query string params as the thumbnail in the poster tag

kylegilman commented 8 years ago

Interesting. I've never heard of signed URLs. I'll look into this, but I wouldn't expect it to work any time soon. I suspect there are some fundamental problems with the way <source> tags are made that will make this difficult to implement.

kylegilman commented 8 years ago

I'm finally going to do some testing on this. What plugin were you using to generate the AWS signed URLs?

ocasta commented 8 years ago

The plugin source is here https://github.com/ocastastudios/wordpress-aws-signed-url

kylegilman commented 7 years ago

This was embarrassingly simple. wp_check_filetype needs an extension at the end of the string and doesn't understand query strings, so when the plugin checked if the original URL was a compatible filetype, the answer was always no. It's been almost a year since you brought this to my attention and I thought it was a much more complicated problem than it was. I apologize and I doubt you're still using my plugin, but your plugin was a big help in solving the problem.

ocasta commented 7 years ago

That's great news. Looking forward to being able to offer our customers secure URLs.

kylegilman / video-embed-thumbnail-generator

AWS CloudFront signed URLs breaking Video tag generation #299