search

kylegilman / video-embed-thumbnail-generator

A WordPress plugin that generates thumbnails, HTML5-compliant videos, and embed codes for locally hosted videos. Requires FFMPEG or LIBAV for encoding.
http://wordpress.org/plugins/video-embed-thumbnail-generator/
GNU General Public License v2.0
48 stars 27 forks source link

Add digitaloceanspaces.com to Exempt CDN list so Download link works. #450

Closed presswizards closed 5 years ago

presswizards commented 5 years ago

I'm using the Download Log plugin, and need the Download link to track CDN downloads. We're using Digital Ocean Spaces right now, so I added it to the exempt check.

It'd be great if this was a text-area on the options page to paste in other domains that should be considered exempt.

kylegilman commented 5 years ago

I'm happy to add this to the list, but I think the problem needs a better solution than adding to a soon-to-be endless list of CDNs. I don't like the idea of accepting plain-text URL inputs. A simple check box to disable URL re-writing is what I'm leaning towards, but can you walk me through the details of your problem? It's not obvious to me what the connection is between hosting your videos on a CDN and a download log plugin. Which download log plugin are you using? And why doesn't wp_get_attachment_url return the correct URL? What other plugins are you using to offload your Media Library?