kylegoetz / tree-sitter-unison

Tree Sitter grammar for Unison programming language
MIT License
7 stars 8 forks source link

make proper releases including the generated artifacts #59

Closed kylegoetz closed 6 months ago

kylegoetz commented 6 months ago

splitting this into its own issue but originally brought up by @clason in #56

consider making proper releases including the generated artifacts (which is what nvim-treesitter will require for "stable" parsers). Upstream is in the process of adding reusable workflows and tree-sitter support to make this easier.

https://github.com/tree-sitter/workflows

kylegoetz commented 6 months ago

latest in test process https://github.com/kylegoetz/tree-sitter-unison/actions/runs/8665499830/job/23764328299#step:4:436

undef references to tree_sitter_unison_external_scanner_deserialize and its ilk. These are confirmed present in src/scanner.c

kylegoetz commented 6 months ago

Working on this now. The npm-publish workflow provided by Tree Sitter errors out with an illegal cast (or, rather, a failed assert based on a problematic cast) in Node's own source code. Looking to see what might be the issue.

kylegoetz commented 6 months ago

Windows build fails, output is confusing. Looks like the build process invokes prebuildify with invalid arguments?

ObserverOfTime commented 6 months ago

You need to run tree-sitter generate to update the bindings. Then manually fix the missing scanner and incorrect metadata.

kylegoetz commented 6 months ago

@ObserverOfTime turns out prebuildify has a bug with a PR waiting to fix it

https://github.com/prebuild/prebuildify/pull/84

I've already re-generated and manually fixd the missing scanner. Prebuildify on Windows appears to fail specifically because of this issue: https://github.com/prebuild/prebuildify/issues/83 so I'm just waiting for the PR to be accepted and then nopefully the NPM deployment workflow will work again. It seems this is an issue with Windows Node 20 where they forbid the use of files with a certain file extension unless shell: true is set in the opts, and it's currently not

kylegoetz commented 6 months ago
Screen Shot 2024-04-15 at 12 03 11 PM
kylegoetz commented 6 months ago

finished and 1.1.2 built and uploaded to NPM