kylejbrk / standard-notes-open-extended

A Free Open Source Standard Notes Extensions Repository Hosted via Github Pages
https://kylejbrk.github.io/standard-notes-open-extended/
GNU General Public License v3.0
111 stars 58 forks source link

Adds FileSafe extension #11

Closed ashutoshsaboo closed 2 years ago

ashutoshsaboo commented 2 years ago

FileSafe extensions from here - https://github.com/standardnotes/filesafe-bar

ashutoshsaboo commented 2 years ago

Hey @kylejbrk - can you merge this? This was missing earlier from the repo

kylejbrk commented 2 years ago

Did you test to see if this extension works? If memory serves i left this out since it worked differently from the other extensions.

I'd recommend running the build.py on your fork and try importing the index.json to confirm it works.

ashutoshsaboo commented 2 years ago

working already - https://raw.githubusercontent.com/ashutoshsaboo/standard-notes-open-extended/gh-pages/file-safe/index.json

ashutoshsaboo commented 2 years ago

can you merge this PR - @kylejbrk ?

kylejbrk commented 2 years ago

Looks like the url is off in your index.json image

Regardless I think this is safe to add for now. Thanks.

ashutoshsaboo commented 2 years ago

That must have been something wrong with my fork's github action setup - the url field looks okay here - https://raw.githubusercontent.com/kylejbrk/standard-notes-open-extended/gh-pages/file-safe/index.json