Closed vincentropy closed 6 years ago
Updates related to #12
I updated smoothed_moving_average because I think the behavior of that function was incorrect. I replaced it will a function call from pandas.
I updated ATR to not use a recursive formulation, but instead simply call smma. This should help with issues with nans in the middle of a dataset.
I added parenthesis to the ADX function.
These changes result in different outputs for the affected functions so I updated the corresponding tests as well.
I'm very open to feedback.
Thanks @vincentropy this looks great! I'll make a minor release during my lunch and push it to pypi.
Thanks a lot @kylejusticemagnuson, for the quick merge!
Updates related to #12
I updated smoothed_moving_average because I think the behavior of that function was incorrect. I replaced it will a function call from pandas.
I updated ATR to not use a recursive formulation, but instead simply call smma. This should help with issues with nans in the middle of a dataset.
I added parenthesis to the ADX function.
These changes result in different outputs for the affected functions so I updated the corresponding tests as well.
I'm very open to feedback.