kylekatarnls / business-time

Carbon mixin to handle business days and opening hours
MIT License
297 stars 14 forks source link

Add php-7.4 version test #18

Closed peter279k closed 4 years ago

peter279k commented 4 years ago

Changed log

peter279k commented 4 years ago

The StyleCI is failed because there is no .styleci.yml setting on the original master repository.

peter279k commented 4 years ago

Should we use this setting for the .styleci.yml?

enabled:
  - concat_with_spaces

disabled:
  - short_array_syntax
  - concat_without_spaces
  - single_quote
codecov[bot] commented 4 years ago

Codecov Report

Merging #18 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #18   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      110    110           
=======================================
  Files             7      7           
  Lines           246    246           
=======================================
  Hits            246    246
Impacted Files Coverage Δ Complexity Δ
src/Cmixin/BusinessTime.php 100% <ø> (ø) 8 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10cc8f3...247d43a. Read the comment docs.

kylekatarnls commented 4 years ago

Should we use this setting for the .styleci.yml?

Nope, I progressively remove them from my repositories to use the default settings instead. And you can use StyleCI website to create and apply the modifications.

peter279k commented 4 years ago

@kylekatarnls, thanks for your reply.

I've enabled the StyleCI service for this forked repository and fix coding style.

The StyleCI result link is as follows:

https://github.styleci.io/analyses/kaYjE1

You can look at that.

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 247d43a8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0%.

View more on Code Climate.

kylekatarnls commented 4 years ago

Thanks.

peter279k commented 4 years ago

@kylekatarnls, just notice that the StyleCI is misconfigured on original repository.

The error link is here.

I guess this configuration should be changed. And you should solve that by yourself.