kylekatarnls / business-time

Carbon mixin to handle business days and opening hours

MIT License

296 stars 14 forks source link

Update README.md #29

Closed Ken-vdE closed 4 years ago

Ken-vdE commented 4 years ago

There were some errors in the readme file.

The enable should be for 'Time' not 'Day'.
The example laravel carbon.php was in the wrong format and caused "Spatie\OpeningHours\Exceptions\InvalidDayName: Day opening-hours isn't a valid day name. Valid day names are lowercase english words, e.g. monday, thursday."

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 535c0209 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

codecov[bot] commented 4 years ago

Codecov Report

Merging #29 into master will not change coverage. The diff coverage is n/a.

@@             Coverage Diff             @@
##              master       #29   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       228       228           
===========================================
  Files             16        16           
  Lines            508       508           
===========================================
  Hits             508       508

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98b331d...535c020. Read the comment docs.

kylekatarnls commented 4 years ago

Thank you, the array definition does not match the expected config properties. I have to check this point.