search

kylekatarnls / business-time

Carbon mixin to handle business days and opening hours
MIT License
296 stars 14 forks source link

Fix #34 holidays detection via static methods like isOpenOn #35

Closed kylekatarnls closed 4 years ago

kylekatarnls commented 4 years ago

Fix #34 holidays detection via static methods like isOpenOn()

codecov[bot] commented 4 years ago

Codecov Report

Merging #35 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #35   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       237       239    +2     
===========================================
  Files             16        16           
  Lines            528       539   +11     
===========================================
+ Hits             528       539   +11
Impacted Files Coverage Δ Complexity Δ
src/BusinessTime/DefinitionParser.php 100.00% <100.00%> (ø) 26.00 <2.00> (+1.00)
src/BusinessTime/DiffCalculator.php 100.00% <100.00%> (ø) 16.00 <2.00> (+1.00)
src/BusinessTime/MixinBase.php 100.00% <100.00%> (ø) 48.00 <1.00> (ø)
src/BusinessTime/Traits/Diff.php 100.00% <100.00%> (ø) 10.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fc17619...907ca9c. Read the comment docs.

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 907ca9ce and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.