search

kylekatarnls / business-time

Carbon mixin to handle business days and opening hours
MIT License
297 stars 14 forks source link

IDE Helper Files part of the distribution #54

Closed benfreke closed 2 years ago

benfreke commented 2 years ago

Hi

Great plugin.

I'm using PhpStorm, and when Carbon is included in my project, it is complaining about multiple Definitions.

I think this is due to extra files being included in the distribution when they shouldn't be. Specifically the entire types and .github directories.

Are you open to a PR fixing this, or did you want to fix this yourself? Given it'll be part of the build process I'm not certain this is something I could/should fix?

Screen Shot 2022-05-06 at 4 37 39 pm

kylekatarnls commented 2 years ago

Hello,

Removing types will break the auto-completion. It's there to enable the following feature: image

If you remove it, only the methods business-time will remain: image

Multiple definitions is actually expected to happen when using the macro/mixin pattern as methods are added to an existing class that is not itself modified.

If there is an other syntax that IDEs would understand (still provide the auto-completion as per the screenshots above) and not trigger any multiple-definitions notice, I'm OK to merge this change. But removal or exclusion from the distribution package is not an option.