search

kylekatarnls / business-time

Carbon mixin to handle business days and opening hours
MIT License
297 stars 14 forks source link

No Holidays when using Schedule instances #62

Closed TNTLarsn closed 1 year ago

TNTLarsn commented 1 year ago

Test on PHPSandbox

kylekatarnls commented 1 year ago

I have holidays: https://phpsandbox.io/e/x/7548o?layout=EditorPreview&defaultPath=%2F&theme=dark&showExplorer=no&openedFiles=

Can you confirm custom holidays (holidays.with option) is missing? As this is the only option not giving expected result as per the given example.

TNTLarsn commented 1 year ago

No, I can not confirm this, as of your holiday "2022-12-25 09:40:00" is a sunday anyway. Try "2023-12-25 09:40:00"which is a monday and ->isopen() will return true

kylekatarnls commented 1 year ago

Sorry for the delay, it's now fixed in 1.12.1.