search

kylemanna / docker-aosp

🏗 Minimal Android AOSP build environment with handy automation wrapper scripts
https://registry.hub.docker.com/u/kylemanna/aosp/
MIT License
507 stars 239 forks source link

Fixed default volume sharing for Boot2Docker #6

Closed bydavy closed 10 years ago

bydavy commented 10 years ago

This fixes #3, but it makes the script more fragile as the executing user determines the default volume, -see: "$HOME/vol0"-

kylemanna commented 10 years ago

I don't think I like that change. :-1: The default /vol0 mount was meant to be overridden, and was picked to be simple and short, and by default would work in the vast majority of cases.

Putting the volumes in the user's home directory is a recipe for disaster as the aosp user is extremely unlikely to ever have the same uid as the docker client's calling user. This means there will be a bunch of files under a user's home that the user doesn't own. This feels wrong.

It might be possible to detect a boot2docker environment by looking for .boot2docker in the DOCKER_CERT_PATH env variable and then override this variable to make it work in this special case. Thoughts?

bydavy commented 10 years ago

I agree and I think it's irrelevant now as you recommend to use kylemanna/vagrant-aosp.