search

kylemanna / docker-bitcoind

💰 Bitcoind Docker image that runs the Bitcoin node in a container for easy deployment
https://hub.docker.com/r/kylemanna/bitcoind/
MIT License
627 stars 406 forks source link

Release management proposal #93

Open tomav opened 3 years ago

tomav commented 3 years ago

Hi,

First, good job on this project, have been using it for months and works really good.

I was wondering if you ever thought of having a release available per bitcoin version. Today there's only a latest on docker hub, which does not tell which version we're running.

Lightning Networks actually works like this as you can see on their release page. For the lnd v0.13.1-beta there's a lightninglabs/lnd:v0.13.1-beta docker image.

Docker action can help on this.

Thanks.

vanthome commented 2 years ago

This is essential to use this container on Kubernetes. Can the author please tell whether they want to implement this?

kylemanna commented 2 years ago

Hmm, I'd consider tagging per release but think it's kind of hard to get to a good versioning scheme that is future proof enough.

Thoughts on bitcoind:$UPSTREAM_TAG[-$DOCKER_PATCH]

Examples:

bitcoind:v22.0 (also `latest`)
bitcoind:v0.21.2
bitcoind:v0.21.2-1
bitcoind:v0.21.2-2

Biggest concern would be implementing some testing to make sure this doesn't break and nobody notices.

rubo commented 1 year ago

I want to stress the importance of having a tag per Bitcoin Core version. It's a pity this issue is still open. @kylemanna, could you please prioritize this?