kylemcdonald / LightLeaks

An immersive installation built from a pile of mirror balls and a few projectors.
Other
93 stars 14 forks source link

Deleted dependency detected #84

Open ashishbijlani opened 9 months ago

ashishbijlani commented 9 months ago

I'm a Cyber Security researcher and developer of PackjGuard [1] to address open-source software supply chain attacks.

Issue

During my research, I found that this repo is vulnerable to attack due to deleted dependency from the public PyPI registry.

Details

Specifically, file https://github.com/kylemcdonald/LightLeaks/blob/f72719c4f46e4ec0cf8f37b520f7be859381d43b/python/requirements.txt lists click8 as one of the dependencies. However, it has been deleted from public PyPI. As such, an external bad actor can claim that name and register a malicious package, which will be then installed with pip install command, resulting in arbitrary remote code execution.

Impact

Not only your apps/services using https://github.com/kylemcdonald/LightLeaks repo code are vulnerable to this attack, but the users of your open-source Github repo could also fall victim.

You could read more about such attacks here: https://medium.com/@alex.birsan/dependency-confusion-4a5d60fec610

Remediation

Please manually register a placeholder click8 package on PyPI immediately or remove click8 dependency from https://github.com/kylemcdonald/LightLeaks/blob/f72719c4f46e4ec0cf8f37b520f7be859381d43b/python/requirements.txt to fix this vulnerability.

To automatically fix such issues in future, please install PackjGuard Github app [1].

Thanks!

  1. PackjGuard is a Github app that monitors your repos 24x7, detects vulnerable/malicious/risky open-source dependencies, and creates pull requests for auto remediation: https://github.com/marketplace/packjguard