search

kylemcdonald / ofxCv

Alternative approach to interfacing with OpenCv from openFrameworks.
Other
657 stars 276 forks source link

Correction to saving/loading in Calibration.cpp #243

Closed golanlevin closed 6 years ago

golanlevin commented 6 years ago

Line 127 in Calibration.save() appears to cause errors (owing to the introduction of superfluous brackets) when an attempt to load the saved file is later made. I corrected the problem by changing fs << "[:" << imagePoints[i] << "]"; // previous code to fs << imagePoints[i]; // new code

kylemcdonald commented 6 years ago

this code was originally added by @obviousjim https://github.com/kylemcdonald/ofxCv/commit/f4d601bb999a6e8e536137f186237f9128d691a4#diff-6858fad26cb259fa2421ef6cbf5aa36aR93

and i have no clue what the format is, so i can't really comment on whether you've made a change that is more correct or less correct.

but if this change makes saving & loading work together, i consider it a win. :) so i will merge.

tyhenry commented 6 years ago

can this be merged to master also? same issue there

kylemcdonald commented 6 years ago

@tyhenry i just merged it into master. please check that it's working. thanks.

tyhenry commented 6 years ago

working fine, thanks!