search

kylemcdonald / ofxEdsdk

Interfacing with Canon cameras from openFrameworks for OSX. An alternative to ofxCanon and CanonCameraWrapper.
Other
112 stars 51 forks source link

Fix 2.12 #10

Closed roymacdonald closed 11 years ago

roymacdonald commented 11 years ago

related to https://github.com/kylemcdonald/ofxEdsdk/issues/8

kylemcdonald commented 11 years ago

ok, i can see it more clearly now -- thanks :)

so in this new structure, live view doesn't start until you call restetLiveView()? if so, that's problematic. if your code asks for live view, it should start without you needing to call resetLiveView() after the camera is available.

also, it looks like you're using spaces instead of tabs :) if you could switch that'd be great, but if you don't i can switch it for you.

roymacdonald commented 11 years ago

The thing is that if liveview is opened inmediatelly after opening the session the app hangs. So maybe adding a timer and starting liveview a few seconds after opensession might work. I'll check it later. It's just xcode using spaces instead of tabs. I'll fix that later also. Best!

kylemcdonald commented 11 years ago

ok -- we should figure out exactly how long that delay is, and add it to ofxEdsdk so people don't have to figure it out for themselves. but congrats on determining that is the only issue :)

roymacdonald commented 11 years ago

Sure, I'll try it later. Thanks. BTW, this wasn't the only issue. I had to add an autoreleasepool, because there was a leak inside the sdk.

roymacdonald commented 11 years ago

@kylemcdonald I just added the timer for the liveview initing. It works fine with my t2i. I guess it should work with other cameras. for some reason this timer wasn't working if inside the threadedFunction, so that's why it is inside the update. Also added a few things needed for this to work on windows. It works fine on win7 x64. best!

kylemcdonald commented 11 years ago

thanks so much!