kylemcdonald / ofxEdsdk

Interfacing with Canon cameras from openFrameworks for OSX. An alternative to ofxCanon and CanonCameraWrapper.

Other

112 stars 51 forks source link

Implemented the movie recording feature. #19

Closed smallfly closed 10 years ago

smallfly commented 10 years ago

Hi,

Here is a first implementation of the movie recording feature (it includes all the commits from my previous PR). Next step would be to do some refactoring to replace some occurrences of the word 'photo' by 'item'.

Let me know.

Hugues.

kylemcdonald commented 10 years ago

looking good, a couple questions:

which version of the sdk did you test this on
which OS did you test on

smallfly commented 10 years ago

All these have been tested using the Canon SDK 2.14, on both OS X and Windows 8.1. The only thing not tested on Windows is the use of EdsDirectoryItemInfo (in this commit) to define the type of media we are dealing with (photo or video). I could test this later this week.

One thing I’m not please with, is that I had to define :

define OFX_EDSDK_JPG_FORMAT 14337

define OFX_EDSDK_MOV_FORMAT 45316

I could not find those in the Canon SDK.

kylemcdonald commented 10 years ago

thanks! refactoring is still welcome, but this is very helpful. i'll delete my other branch now that this is in here.