kylemcshea / dream-postal

📦GoPostal Job for FiveM: Made for QB & ESX. Integrated with ox_target & qb-target for a premium gameplay experience. Elevate your server now! 🚀
https://www.youtube.com/watch?v=fSwJO3C85E0
55 stars 12 forks source link

Protect exploits from cheaters. #18

Closed Misha0717 closed 11 months ago

Misha0717 commented 11 months ago

Removed all the client sided 'discord logs' logic and also created server sided checks on cheaters instead client sided.

kylemcshea commented 11 months ago

I think we need to remove this snippet of code since we are no longer using the log function client side

---@param data { type: 'success' | 'error', message: string }
function log(data)
    local type = data.type
    local message = data.message

    local logData = {
        type = type,
        message = message,
        postalJobState = (type == 'error') and postalJobState or nil,
    }

    TriggerServerEvent('dream-postal:server:log', logData)
end
Misha0717 commented 11 months ago

yeah you are right on all the changes 😂 I created a commit to fix all these things. 👌

kylemcshea commented 11 months ago

Code looks amazing

Now I just need to run this on my server double check all functionally works and I'll merge your pr ✨

Misha0717 commented 11 months ago

<3