search

kyleneideck / BackgroundMusic

Background Music, a macOS audio utility: automatically pause your music, set individual apps' volumes and record system audio.
GNU General Public License v2.0
15.91k stars 674 forks source link

You have 3rd party communication (Google) in your app. Websockets? Auth? WTF? #585

Open TimSusa opened 2 years ago

TimSusa commented 2 years ago

Ey Mister, I see you are running into major problems. For example I do not care about the auto pause feature. I just wanna have the volume sliders. So I do not even wanna have all that extra unneeded code with Google, Websockets, Auth.. music players... Wouldn´t you agree, that you better make the app pluggable for all those players? and host further brew packages or npm packages? So now what happens as you already see you try to support too much of different stuff the same time. This brings you in the situation to explain a lot even in the Readme. Do you see the major complexity increases now, you have 381 Issues and a lot of major stablitly problems. Even the aggreate device crashes with your app. You will lose your overall focus if your not change something now.

Best Regards

shiftux commented 2 years ago

First off, @kyleneideck, you did some awesome work and you should be thanked and praised!

☝️ above comment is not formulated very favorably, IMO. But I second the underlying message... The current state of your app could benefit from some focus and stability. Thanks for all the effort you put in @kyleneideck !