kyleolsz / TB-Networks

77 stars 18 forks source link

404 not found error in your new car checkpoint #2

Closed xiaobaozi1996 closed 4 years ago

xiaobaozi1996 commented 4 years ago

Hello, the link of your pretrained model on car dataset isn't available now, can you check the link in the readme file? Thanks!

kyleolsz commented 4 years ago

Hi,

Sorry, the old links were deactivated. The links have been updated with new models that should be available now.

You should also pull the latest version of the code, as these updated models are slightly different than the original models. The original models were slightly different than those described in the supplementary material of the paper (e.g., bottleneck resolution and final output resolution). The new models and resulting images are thus more consistent with those seen in the paper.

kyleolsz commented 4 years ago

Both models are in Dropbox and the updated links appear to work, are you unable to download the chair model?

On Thu, Dec 5, 2019 at 1:24 AM maoyali notifications@github.com wrote:

The updated model of car dataset is available, When do you update the pretrained model of chair dataset?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kyleolsz/TB-Networks/issues/2?email_source=notifications&email_token=ACEJVUDDHDM5HBIKQFA4N53QXDCDFA5CNFSM4JNHGJ32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGABXFI#issuecomment-562043797, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACEJVUGAWUC4MV54CTTJ7VDQXDCDFANCNFSM4JNHGJ3Q .

xiaobaozi1996 commented 4 years ago

Thank you very much, it's ok now~

xiaobaozi1996 commented 4 years ago

Hi, I test your model quantitatively. The result is as follows: image It's inconsistent with the paper:
image The value of L1 exists huge difference? Why? Is there any transformation at the end?

kyleolsz commented 4 years ago

A couple of points:

From looking at the code in their repository, it appears that they apply some rescaling (by a factor of 1.5) to the raw L1 value to the L1 results for the results on ShapeNet objects. They also seem to use a different range for the image pixel values (values in the range of -1 to 1, while in our framework images are in the range of 0 to 1).

So it makes sense that the reported values obtained using their framework would be higher than those in ours. If you just want to use the raw L1 loss for images with pixel values in the range of 0 to 1, you can use the results from our evaluation code.

xiaobaozi1996 commented 4 years ago

Ok, I got it! Thanks~ My research is very relative to your Paper. I want to know more details about the model and I send some doubts about it to your email. Please check it~