kylerberry / JACT

Just Another Crypto Trader. (gdax crypto trading bot)
3 stars 0 forks source link

Stop Loss not added to manager.filled #23

Closed kylerberry closed 6 years ago

kylerberry commented 6 years ago

if a stop loss order occurred, it did not add the filled order to the manager.filled model. This would cause subsequent LONG orders to not be placed and might cause subsequent SHORT orders to sell position that it didn't initially own.

Stop loss is a market order so it never hits the feed due to it never hits the order book, it is filled immediately. So skip the feed if stopLossTriggered

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 26


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/TraderBot.js 0 15 0.0%
<!-- Total: 0 15 0.0% -->
Totals Coverage Status
Change from base Build 24: 2.5%
Covered Lines: 166
Relevant Lines: 399

💛 - Coveralls