kylerberry / JACT

Just Another Crypto Trader. (gdax crypto trading bot)
3 stars 0 forks source link

API /config #26

Closed kylerberry closed 6 years ago

kylerberry commented 6 years ago

👍

run npm run jact navigate to localhost:PORT/config you will see the currently used config

screen shot 2018-02-24 at 3 51 08 pm
kylerberry commented 6 years ago

@ZurabWeb I took your config route and added it to the bot's app.js. I also removed bin/www because it's basically doing manually what express does auto-magically.

ZurabWeb commented 6 years ago

@kylerberry Tests are failing

kylerberry commented 6 years ago

@ZurabWeb i have to look into why the tests are failing because they pass locally

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 41


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/CandleProvider.js 1 2 50.0%
lib/Strategy.js 6 7 85.71%
lib/TraderBot.js 16 27 59.26%
lib/PortfolioManager.js 115 137 83.94%
<!-- Total: 139 174 79.89% -->
Files with Coverage Reduction New Missed Lines %
lib/TraderBot.js 2 43.96%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 30: 2.7%
Covered Lines: 224
Relevant Lines: 394

💛 - Coveralls
kylerberry commented 6 years ago

@ZurabWeb huzzah! tests are passing