kylerberry / JACT

Just Another Crypto Trader. (gdax crypto trading bot)
3 stars 0 forks source link

better solution for remainder positions less than minimum order size #31

Closed kylerberry closed 6 years ago

kylerberry commented 6 years ago

fix for https://github.com/kylerberry/JACT/issues/29

ok, i think this is a better solution. it may require some changes to the manger.info calculations, because the threshold for calculating a 'win' vs a 'loss' is changed.

instead of the bot trying to sell 100% of a position before moving on, it will sell until the remainder is < the minimum order size. this is different for each trading pair. e.g. (.1 for LTC, .01 for ETH). At this point it will allow purchasing to continue. Any remainders from previous sells will be appended onto subsequent sell orders.

I'll open an issue for the info calculation when i have a better idea of how it's been affected.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 46


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/PortfolioManager.js 11 13 84.62%
<!-- Total: 20 22 90.91% -->
Totals Coverage Status
Change from base Build 42: 1.7%
Covered Lines: 237
Relevant Lines: 399

💛 - Coveralls