search

kylereicks / picturefill.js.wp

A WordPress plugin to use Picturefill.js for image loading.
106 stars 10 forks source link

Next steps #1

Closed kylereicks closed 11 years ago

kylereicks commented 11 years ago

I like picturefill.js, it's simple, light, and does the trick, mostly. As much as I don't like to do this, I think the next step is to edit picturefill itself. I'm not thrilled with the way the browser treats the empty divs. I'd like to try implementing the proposed picture element more directly, but barring that I'll swap out divs for spans so that the elements are inline by default.

kylereicks commented 11 years ago

Put together a version using spans instead of divs. The browser seems to like the way this works better. I think I will still put together another branch attempting a more direct implementation of the proposed 'picture' spec.

kylereicks commented 11 years ago

I think both the spans and picture branches are an improvement on the original. Next steps include more browser testing, and then deciding what to merge to master.

kylereicks commented 11 years ago

Merged the spans branch to master. The picture branch works, but I'm going to wait on it until the picture spec has been adopted. If it ever is adopted.

gentle-media commented 11 years ago

@kylereicks I don;t have experience with Github, or actually not with the way how things work here, so apologies if I place this at the wrong section.

I was looking for a WP plugin that mimics the picturefill, so I ended up here. I was wondering if your script is save to use in a production environment? How far back in IE versions did you tested it?

kylereicks commented 11 years ago

@gentleone I have not tested the plugin in IE at all. I have just followed @scottjehl's instructions for lt IE9 support.

I will try to set up a development environment for IE testing this weekend and report back. If you do any of your own testing, I would be happy for the feedback.