allow_url_fopen=0

[reimersjan]

i get this error

Warning: getimagesize(): http:// wrapper is disabled in the server configuration by allow_url_fopen=0 in /super/secret/path/on/my/server/wp-content/plugins/picturefillwp/inc/class-model-picturefill-wp.php on line 123

why does picturefillwp need allow_url_fopen to be activated?

[kylereicks]

Good catch. I didn't notice that getimagesize() required any special Apache modules.

I added getimagesize() to the model to cover a pretty specific situation. To determine if we need to make a new image, we need to check the height and width of the image file we are looking at. At first, I tried grabbing the -{width}x{height} that WordPress adds to all of its generated images, but this ran into trouble with some of the images in the WordPress theme unit tests that already had -{width}x{height} appended on to the full-size image file name.

I thought that getimagesize() would simplify things, but I don't want to require allow_url_fopen. Unless a more clever solution presents itself, I'll probably use ini_get to check for allow_url_fopen before using getimagesize(). If allow_url_fopen is not active, I'll try the -{width}x{height} solution mentioned previously. Worst case scenario, images will be occasionally created where they are not needed, but the caching implemented with version 1.2.0 should minimize this.

I'll get a bugfix branch started and hopefully we can push something to the plugin SVN by the end of the week.

Let me know if you have any ideas or notice anything else that should be addressed.

Thanks very much.

[reimersjan]

i've tried 1.2.1. seems to be fixed. no error output