search

kylestetz / slang

🎤 a simple audio programming language implemented in JS
http://slang.kylestetz.com
ISC License
1.19k stars 31 forks source link

Add additional drum kits #5

Open kylestetz opened 6 years ago

kylestetz commented 6 years ago

The (drums) function can be extended to support a type argument, e.g. (drums 2), which controls what set of samples is played. A precedent around lazy loading each kit was already established in Drums.js; extending this should be easy and won't force users to download audio files unnecessarily.

ghost commented 6 years ago

Wow ;D this is cool

agbales commented 6 years ago

@kylestetz, are you thinking this will always draw samples from /public/audio/acoustic via loadDrumSounds and drumMap?

If I'm understanding that right, I'll take this one on!

kylestetz commented 6 years ago

Hey @agbales, someone already started taking this on in PR #10! Happy to have you pop in there and give some additional feedback if you're interested. I will probably be very slow at responding to/merging anything in this project 😅