USPS Provider not submitting "LARGE", "Width", "Height", etc

kylewest / DotNetShipping

UPS, FedEx, USPS shipping rate calculators for .NET

MIT License

80 stars 66 forks source link

USPS Provider not submitting "LARGE", "Width", "Height", etc #21

Closed jbrianskog closed 5 years ago

jbrianskog commented 10 years ago

Hello, I noticed that USPSProvider.cs has a TODO at line 91 in GetRates() and submission of the dimension props are commented out. USPS specs says it needs the dimensions for "LARGE" packages. Should GetRates() actually be passing this info and this just hasn't been implemented yet or is there some other reason it hasn't been done (e.g. maybe USPS typically ends of giving the same rates for REGULAR and LARGE)?

kylewest commented 10 years ago

I apologize as I don't remember the exact reasoning; however, I do remember submitting the dimensions caused the USPS provider to stop returning results. USPS has some odd rules for how things are submitted that I didn't have the time to troubleshoot. Ideally the provider would look at the dimensions, figure out if it is large or not, and submit appropriately.

Kyle