search

kylewest / DotNetShipping

UPS, FedEx, USPS shipping rate calculators for .NET
MIT License
78 stars 66 forks source link

AppVeyor build fails on Pull Requests #48

Closed Soulfire86 closed 8 years ago

Soulfire86 commented 8 years ago

@kylewest Not sure if you already knew this, but I looked into why the build fails on every PR and it turns out that it is because the Environment Variables are encrypted, and that by design AppVeyor won't use secured variables when building on a Pull Request since it could be a security risk.

So, I wanted to throw out 2 options I could see off the top of my head: 1) In the settings, isn't there a way to just to not auto build on PRs? 2) Just use some unencrypted credentials that are all just dev/test creds for each provider?

kylewest commented 8 years ago

Makes sense, someone could add a test that prints out the variables and see them in plain text. probably best to just disable the builds unless there are published test account credentials for the providers (I don't think there are).

Kyle

Soulfire86 commented 8 years ago

Yeah, it's be awesome to have tests run on PRs but just doesn't seem easy to do here where credentials are needed.

I don't think I have access to turn this off, but it should be in the Webhooks & Services part of the settings for the repo:

image

kylewest commented 8 years ago

@Soulfire86 thanks for all the info. I disabled that in our settings. should be good to go now.