search

kylewlacy / GhidraNes

Ghidra extension for loading iNES 1.0 NES ROMs
51 stars 11 forks source link

INES mapper 2 with fixed upper bank #16

Open Saph32 opened 3 months ago

Saph32 commented 3 months ago

Hello,

First, thank you for your project.

I started disassembling "The Guardian Legend", which is mapper 2 (UNROM).

I noticed that this game has fixed upper ROM bank (c000-ffff) and switchable lower bank ROM (8000-bfff)

It seems to be the default behavior, as documented here : https://www.nesdev.org/wiki/UxROM#Bank_select_($8000-$FFFF)

kylewlacy commented 3 months ago

Ahh, so it seems like this could be a bug with how mapper 2 is handled? Or just new behavior?

In any case, I probably won't have much capacity to work on GhidraNes in quite some time, but in the meantime I'd be open to reviewing a PR for this change or providing guidance for anyone interested in trying to work on a contribution