search

kylewlacy / GhidraNes

Ghidra extension for loading iNES 1.0 NES ROMs
51 stars 11 forks source link

remove extraneous "new" from exception throw in build.gradle #9

Closed CBongo closed 1 year ago

kylewlacy commented 1 year ago

Thanks for contributing this, but I'm hesitant to merge it without a good reason because the build.gradle file was auto-generated the Eclipse "Ghidra Module Project" template from the GhidraDev extension (and especially because the code modified is in a section marked as "DO NOT MODIFY" in the template).

I'd lean more towards sticking with the upstream template as-is over customizing it. If there is some benefit to taking out this new, I'd prefer to merge this change in only if Ghidra upstream adopts it as well (unless there is a strong reason to merge it in anyway). For reference, here's the version of the file from Ghidra itself (the one in GhidraNes is from an earlier Ghidra release): https://github.com/NationalSecurityAgency/ghidra/blob/007cfacd6cba3bb8d50e2ec78c9521025a5c7fcd/GhidraBuild/Skeleton/buildTemplate.gradle#L32

CBongo commented 1 year ago

Looks like this change was not actually necessary; I can't reproduce the error any more. I also tend to agree that messing with the DO NOT MODIFY section of the file is the right approach anyway - I should have just pulled in the latest from the skeleton if that fixed it.