kylewm / redwind

Flask-based personal website #IndieWeb #OwnYourData
Other
45 stars 5 forks source link

Patch bc pilbox chokes on "data:" urls #36

Closed thedod closed 9 years ago

thedod commented 9 years ago

e.g happened here

kylewm commented 9 years ago

lol ok. the database limits contact image URLs to 512 bytes; is that also a problem for data: URLs that you'd want to use?

thedod commented 9 years ago

the database limits contact image URLs to 512 bytes; is that also a problem for data: URLs that you'd want to use?

ZOMG! I didn't think about that. Twister avatars are data:..., but maybe it's not a good idea to copy/paste them into the contact db. The Twister avatar is > 2.5K and MFreitas is almost 4K:exclamation: I wonder: how come nothing crashed so far:question:

kylewm commented 9 years ago

Are you using SQLite in production? I don't believe it enforces column width limits...

thedod commented 9 years ago

Indeed I do. If I ever migrate to something else I guess I'll first need to ditch those data: URLs (no biggie)