atom feed missing pictures

snarfed commented 9 years ago

low priority, obviously! :P example:

kylewm commented 9 years ago

Thanks for the heads up! (Sheesh, it would have been broken for months and I had no idea)

Fixed in https://github.com/kylewm/redwind/commit/104a73a23779e4b6076083dd6fd75396ac3e39eb

snarfed commented 9 years ago

thanks!

snarfed commented 8 years ago

just fyi, looks like this regressed. e.g. here's the top item in your atom feed right now. note the relative /imageproxy url. low priority, obviously!

<content type="html" xml:base="https://kylewm.com" xml:space="preserve">

    &lt;p&gt;What does it mean when Firefox does this? Seems to have a particular issue with &lt;a class=&#34;auto-link&#34; href=&#34;http://Brid.gy&#34;&gt;Brid.gy&lt;/a&gt; right now&lt;/p&gt;

        &lt;a href="https://kylewm.com/2016/01/what-does-it-mean-when-firefox-does-this-seems-to/files/firefox-GET-failure.png">
          &lt;img src="/imageproxy?url=https%3A%2F%2Fkylewm.com%2F2016%2F01%2Fwhat-does-it-mean-when-firefox-does-this-seems-to%2Ffiles%2Ffirefox-GET-failure.png&amp;w=600&amp;h=600&amp;mode=clip&amp;sig=cf5350912e0a47844242fe1c6a34aab4f2d2fafa" />
        &lt;/a>

</content>

kylewm commented 8 years ago

I accidentally posted that note without an image the first time. Is it possible PuSH beat me to fixing it? Or is this happening on all photo posts?

snarfed commented 8 years ago

looks like all of the <img> tags in your atom have relative /imageproxy urls like in the example above.

snarfed commented 8 years ago

oh! it showed up in my reader again just now with the image. maybe due to a new id. so you're probably right, i saw the original imageless post first.

i guess atom parsing and rendering is smarter about relative urls than i guessed. :P

kylewm commented 8 years ago

surprisingly little info about it online, but I think xml:base is supposed to tell it where to base relative urls from. thanks for the heads up!

kylewm / redwind

atom feed missing pictures #76