kylon / Sharedown

Electron application to download Sharepoint videos (especially meant for students)
GNU General Public License v3.0
370 stars 41 forks source link

Sharedown not detecting ffmpeg installation on Apple Silicon #28

Closed tworstwots closed 2 years ago

tworstwots commented 2 years ago

Guessing this has something to do with how Homebrew installs packages to /opt/homebrew by default on Apple Silicon

kylon commented 2 years ago

i don't have an arm mac to test this, what is the path to the ffmpeg bin? i can add that to sharedown and it should find ffmpeg

tworstwots commented 2 years ago

Actually it appears that this function in preload.js is throwing an error:

api.hasFFmpeg = () => {
    const proc = require('child_process');

    try {
        proc.execSync('ffmpeg -version').toString();
        return true;

    } catch (e) {}

    return false;
}

The path to ffmpeg is /opt/homebrew/bin/ffmpeg (same for yt-dlp).

kylon commented 2 years ago

do you have the error message? probably because it cannot find ffmpeg

added homebrew path Sharedown.zip

tworstwots commented 2 years ago

Getting a spinning wheel now:

Screen Shot 2022-02-14 at 9 03 21 AM
kylon commented 2 years ago

ah my fault, missed a comma

Sharedown2.zip

tworstwots commented 2 years ago

Works now, thanks!