Closed FraH90 closed 2 years ago
+ should fix eperm error in windows
t35
After that sharedown gets stuck on the loading screen. i deleted the loading screen from the devtools so i can retry, but the task is stuck on "Waiting for download data..." and the Remove button is disabled. Oh well.
t36 still 401 error.
do you get 401 on t21? if you try multiple times?
wow, on the first try!
please get 1 success and 1 error
about eperm error, when do you get that? after you stop the download and start new one or it happens even when you do not touch it?
i think the eperm error does only happen when i stop the download and start a new one yeah.
t37. out of 4 attempts only the 4th succeeded, i was about to give up lol.
here is 1 failure and 1 success:
no need for success
no need for success
sounds like what i'm gonna say to my dad when he sees my grades...
t4. Anyways. Out of 4 attempts, 0 failed. Sounds like our final test package! :) Looks like you completely changed the approach hehe.
Log? There you go.
Stream V1 videos still work. The EPERM error after stopping downloads and starting new ones still occurs. Also I get an angry message box with an error from YT-DLP a few seconds after I stop downloads midway kek.
Congratulations on the milestone.
i would still wait for others to confirm it is working i think it exists a case of possible bad timing where it can miss the response and throw an error, but if it works 90% of times i m fine with this (and there is a retry option anyway)
have you tried to download multiple times? mean more than 4 just to be sure
about eperm, is it every single time you stop a download? can you show the yt-dlp error on stop? not happening here
I have tried 5 times. The 5th was to get the YT-DLP error just now, and it also succeeded.
The EPERM is almost every single time I stop a download. the "sharedownLog.log.old" file can't normally be deleted. but when i close sharedown it gets deleted on its own. Deleting the "sharedownLog.log" file while sharedown is running fixes it though.
Here is the YT-dlp error:
After the message box is closed the console displays [Violation] 'DownloadFail' handler took 49307ms sharedown.js:622
the yt-dlp error is not an error, it just says you aborted the download
nodejs was not killing the download process on windows (or at least too late) hence why you didn't see that error before
should now stop download correctly on windows
t5. the yt-dlp error now appears earlier than it did before and the exit code is now 1 instead of "aborted" 😅
yeah, it is supposed to be like that, if you see the error on stop, it is working, message will be aborted on release
if any of you @FraH90 @alperokur confirm t5 is working for you too, i ll push a release
thanks all for testing
if any of you @FraH90 @alperokur confirm t5 is working for you too, i ll push a release
thanks all for testing
I'm not at home those days, sorry for the absence, as soon as I'll come back I'll test it
if any of you @FraH90 @alperokur confirm t5 is working for you too, i ll push a release
thanks all for testing
I've come back home, but the videos that were hosted on the new stream 2.0 platform on which I was testing have been deleted -.- So I have nothing to test on it right now..
If @alperokur has them still available he could try.. otherwise we'll need to wait till I have new ms stream 2.0 videos (september/october probably)
i see, since there are other fixes i ll probably push a release anyway at this point, we will see what happens in october
Lately I'm not able to download any video using sharedown.
I'm trying to download one, and after login it opens a new page, a Microsoft Stream page (though it's a video hosted on sharepoint). I guess they're creating a new platform, a new MS Stream for the video hosted on sharepoint.
The login happens successfully, but then it opens this web page, which seems to be the new microsoft stream for sharedown, and it says "player can't load, please try again".
How to fix this? Does sharedown needs to be updated for this new platform?