kylon / Sharedown

Electron application to download Sharepoint videos (especially meant for students)
GNU General Public License v3.0
376 stars 41 forks source link

saving partial results? #47

Closed gg4u closed 2 years ago

gg4u commented 2 years ago

I am experiencing this issue with some videos. The download of fragments works until the end of both video and audio streams, but just at the merging of the two, there is an error (I cannot tell if the error is in the merging or in the last bit of audio, I only see an exit 1 error).

I think it could be useful an option to persist the two tracks, instead of removing them from the temporary folder, so that one may attempt to fix it later or to inspect if some of the two tracks are somehow corrupted that prevent a final merge. What do you think?

Note the error occurred with default throttling, I m trying to lower it and see if something change.

P.s. can you explain what throttling is and how it affects in this context ?

kylon commented 2 years ago

Throttle option is for when you get blocked by sharepoint because of too many downloads

The issue you describe sounds like #20 and the others open about this

Are you using latest ytdlp? I can add an option to disable automatic delete on error

gg4u commented 2 years ago

The issue you describe sounds like https://github.com/kylon/Sharedown/issues/20 and the others open about this

Indeed it seems so, but using the last ytdlp.

I can add an option to disable automatic delete on error I think it can help.

I was able to manually copy the copies of .mp4 and .m4a files, and merge them with ffmpeg. But since they are deleted as soon as t.m4a is finished downloading and an error -1 is found, they do not persit. So I could only copy a .m4a that is not completed, but it worked for merging.

If you persist the files, eventually one can proceed to merge, or could also merge them automatically but add a suffix indicating that the file was recovered e.g.

[name_file]_RECOVERED.mp4

kylon commented 2 years ago

Hm, yea i can try that, iirc there is an option to not generate fragments but merge the file while downloading (it still gives you error) but you end up with a video file I dont remember tho if when i tried the file was valid after the error