kylon / Sharedown

Electron application to download Sharepoint videos (especially meant for students)
GNU General Public License v3.0
349 stars 40 forks source link

not working anymore #49

Closed ValerioTomaino closed 1 year ago

ValerioTomaino commented 2 years ago

today i tried downloading some videos from sharepoint in the same way and settings of the past and it's not working. it opens the video page and can't load it. if i open the video myself, i can see it.

edit: this is the error page Immagine 2022-09-07 101908 if from here i copy the link of the video opened in another browser (same link i think), it works

kylon commented 2 years ago

any error? keep in mind the video will not play on sharedown, thats how it works

it seems they are moving everyone to stream on sharepoint now, but download should work and it works here too

ValerioTomaino commented 2 years ago

nope, no errors from sharedown, seems like it just can't download it unless i do the previous trick

kylon commented 2 years ago

is the link the correct one for sharedown?

ValerioTomaino commented 2 years ago

yup link one, took it in the same way as always: https://uniroma3.sharepoint.com/:v:/r/sites/AA2122-FONDAMENTIDIAUTOMATICA-20801778PANZIERI/Documenti%20condivisi/General/Recordings/Solo%20visualizzazione/General-20220406_140706-Registrazione%20della%20riunione.mp4?csf=1&web=1&e=HXRBgS

this is the second link (working one), i took it from opening the video in sharepoint from another browser. if i paste this after the log in in sharedown, it works https://uniroma3.sharepoint.com/sites/AA2122-FONDAMENTIDIAUTOMATICA-20801778PANZIERI/Documenti%20condivisi/Forms/AllItems.aspx?csf=1&web=1&e=EzgUV7%2F&FolderCTID=0x0120005A4E1F6F1F5A7F4D919F47C68AE4795A&sortField=Modified&isAscending=true&id=%2Fsites%2FAA2122%2DFONDAMENTIDIAUTOMATICA%2D20801778PANZIERI%2FDocumenti%20condivisi%2FGeneral%2FRecordings%2FSolo%20visualizzazione%2FGeneral%2D20220406%5F140706%2DRegistrazione%20della%20riunione%2Emp4&parent=%2Fsites%2FAA2122%2DFONDAMENTIDIAUTOMATICA%2D20801778PANZIERI%2FDocumenti%20condivisi%2FGeneral%2FRecordings%2FSolo%20visualizzazione

kylon commented 2 years ago

i cant repro, it seems a redirect happening after your login

what login method? have you tried to enable chrome data folder and retry download after the first fail?

should log url changes to log file to see if we can find when it goes wrong Sharedownt.zip

ValerioTomaino commented 2 years ago

the login is microsoft one for institutional account, for redirections i don't know, everything is enabled i'll try get the logs for you

sato-shi commented 1 year ago

I saw similar issues. I changed "preload.js" to use Google Chrome instead of Chromium as browser in Puppeteer. Now I can download again.

function _getPuppeteerArgs(puppyExePath, userdataFold) {
        const pargs = {
            //executablePath: _getPuppeteerExecutablePath(puppyExePath),
            executablePath:"/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome",
            headless: false,
            args: ['--disable-dev-shm-usage']
        };
tkgmomosheep commented 1 year ago

I saw similar issues. I changed "preload.js" to use Google Chrome instead of Chromium as browser in Puppeteer. Now I can download again.

function _getPuppeteerArgs(puppyExePath, userdataFold) {
        const pargs = {
            //executablePath: _getPuppeteerExecutablePath(puppyExePath),
            executablePath:"/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome",
            headless: false,
            args: ['--disable-dev-shm-usage']
        };

For Windows, use the code snippet below

function _getPuppeteerArgs(puppyExePath, userdataFold) {
const pargs = {
executablePath:
"C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe",
headless: false,
args: ["--disable-dev-shm-usage"],
};
kylon commented 1 year ago

weird, i still see no error on my pc maybe i ll add an option to set chrome as browser

BorisDeGraaff commented 1 year ago

today i tried downloading some videos from sharepoint in the same way and settings of the past and it's not working. it opens the video page and can't load it. if i open the video myself, i can see it.

edit: this is the error page Immagine 2022-09-07 101908 if from here i copy the link of the video opened in another browser (same link i think), it works

I have the same issue, how does your trick exactly work? Opening the link in another chrome browser does nothing for me.

Edit: updated my version to latest release (5.1.0), new issues appeared. Downgraded to a previous release (5.0.2), this issues appeared to be present again, but now the thing happened which kylon described: the browser with the error closed, but the video did in fact download.

Unfortunately I don't remember which version I was coming from, but it was an old one downloaded around late 2021 I think.

ValerioTomaino commented 1 year ago

Open the video page on another browser then, when you're stuck with Chrome puppet, copy paste the link inside the Chrome puppet. For me worked

Inviato da Yahoo Mail su Android

Il lun, 31 ott, 2022 alle 12:23, @.***> ha scritto:

today i tried downloading some videos from sharepoint in the same way and settings of the past and it's not working. it opens the video page and can't load it. if i open the video myself, i can see it.

edit: this is the error page if from here i copy the link of the video opened in another browser (same link i think), it works

I have the same issue, how does your trick exactly work? Opening the link in another chrome browser does nothing for me.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

brianchen0 commented 1 year ago

Tried to download using Chrome instead of Chromium, still shows the error as below.

image

image

kylon commented 1 year ago

Tried to download using Chrome instead of Chromium, still shows the error as below.

image

image

this is a different thing, see #54

brianchen0 commented 1 year ago

Tried to download using Chrome instead of Chromium, still shows the error as below. image image

this is a different thing, see #54

Got it, thanks Kylon

kylon commented 1 year ago

@ValerioTomaino please try 5.2.1 release

kylon commented 1 year ago

closing for inactivity, should be fixed in latest release