kylon / Sharedown

Electron application to download Sharepoint videos (especially meant for students)
GNU General Public License v3.0
376 stars 41 forks source link

Failde to launch the browser process (Puppeteer error) #55

Closed jathri closed 2 years ago

jathri commented 2 years ago

Hello, updated to last version (5.1.0) and I am stuck with this error: https://i.imgur.com/yvgdRQi.png I read https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md but cannot solve issue. Can you please help? Do I need to install Puppeteer separately? I am Windows 10 user. I have Node.js v16.13.0 installed.

jathri commented 2 years ago

Tried to install Puppeteer to both c:\Users\XXX\AppData\Local\Programs\sharedown\resources\app.asar.unpacked\node_modules\ and C:\Program Files\nodejs\node_modules\npm\node_modules\ to no avail. Please help.

kylon commented 2 years ago

puppeteer is bundled with sharedown, you cannot install it separately

what windows package are you using? portable or installer?

i can try on my windows install tomorrow

jathri commented 2 years ago

Hello, thank you for your reply. It is this one: https://i.imgur.com/ZkOtAPS.png It did not seem that puppeteer was bundled. At least it was not present at: c:\Users\XXX\AppData\Local\Programs\sharedown\resources\app.asar.unpacked\node_modules Only Clipboardy was present. Or Sharedown uses another folder for puppeteer module?

kylon commented 2 years ago

build was bad, please download the latest release again (it is a new package)

jathri commented 2 years ago

Unfortunately, the issue still persist: https://i.imgur.com/yvgdRQi.png Can you please look into it once more?

kylon commented 2 years ago

are you sure the install was successful? the new package is now correct

try to uninstall and install again also, try with latest nodejs release here

jathri commented 2 years ago

I can confirm that issue still persists. Can you please look into attachment? Is everything as should be? sd.pdf

kylon commented 2 years ago

looks good

are you using latest nodejs? 19.x

jathri commented 2 years ago

Use Node.js v19.0.1. Tried to unistall and install again to no avail. And there is nothing in logs folder. Please, help.

kylon commented 2 years ago

~can you try portable version?~

wait, build may still be not working on windows with latest puppeteer, something broke in yarn dist with puppeteer

mattiac2210 commented 2 years ago

Use Node.js v19.0.1. Tried to unistall and install again to no avail. And there is nothing in logs folder. Please, help.

I have the same problem

kylon commented 2 years ago

@mattiac2210 @jathri please test https://github.com/kylon/Sharedown/releases/download/5.1.0/sharedown.Setup.5.1.0.exe

jathri commented 2 years ago

It works. Thank you for fixing this :)

kylon commented 2 years ago

good, i ll push a new release

mattiac2210 commented 2 years ago

good, i ll push a new release

It works me too. Thank you very much ;)