kyma-incubator / compass

A flexible and easy way to register, manage and group your applications
Apache License 2.0
36 stars 82 forks source link

Use the current operation instead of relying on assignment state #3894

Closed nyordanoff closed 5 months ago

nyordanoff commented 5 months ago

Description Currently we determined the formation operation (assign/unassign) based on the formation assignment state. In this PR we determine the formation operation based on the type of the latest assignment operation for the given assignment.

Changes proposed in this pull request:

Related issue(s)

Pull Request status

kyma-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dragobt, la4ezar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kyma-incubator/compass/blob/main/OWNERS)~~ [dragobt,la4ezar] - ~~[components/director/cmd/ns-adapter/OWNERS](https://github.com/kyma-incubator/compass/blob/main/components/director/cmd/ns-adapter/OWNERS)~~ [dragobt] - ~~[components/director/cmd/ordaggregator/OWNERS](https://github.com/kyma-incubator/compass/blob/main/components/director/cmd/ordaggregator/OWNERS)~~ [dragobt] - ~~[components/director/cmd/systemfetcher/OWNERS](https://github.com/kyma-incubator/compass/blob/main/components/director/cmd/systemfetcher/OWNERS)~~ [dragobt] - ~~[components/director/internal/domain/formation/OWNERS](https://github.com/kyma-incubator/compass/blob/main/components/director/internal/domain/formation/OWNERS)~~ [la4ezar] - ~~[components/director/internal/domain/formationassignment/OWNERS](https://github.com/kyma-incubator/compass/blob/main/components/director/internal/domain/formationassignment/OWNERS)~~ [la4ezar] - ~~[components/director/internal/domain/formationconstraint/OWNERS](https://github.com/kyma-incubator/compass/blob/main/components/director/internal/domain/formationconstraint/OWNERS)~~ [la4ezar] - ~~[components/director/internal/formationmapping/OWNERS](https://github.com/kyma-incubator/compass/blob/main/components/director/internal/formationmapping/OWNERS)~~ [la4ezar] - ~~[components/director/internal/tenantfetchersvc/OWNERS](https://github.com/kyma-incubator/compass/blob/main/components/director/internal/tenantfetchersvc/OWNERS)~~ [dragobt] - ~~[tests/director/tests/notifications/OWNERS](https://github.com/kyma-incubator/compass/blob/main/tests/director/tests/notifications/OWNERS)~~ [la4ezar] - ~~[tests/pkg/notifications/OWNERS](https://github.com/kyma-incubator/compass/blob/main/tests/pkg/notifications/OWNERS)~~ [la4ezar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nyordanoff commented 5 months ago

/test pre-main-compass-schema-migrator-validate

ognyvrac commented 5 months ago

/test pre-main-compass-schema-migrator-validate