search

kyma-incubator / compass

A flexible and easy way to register, manage and group your applications
Apache License 2.0
36 stars 83 forks source link

KEB: deleting service instance returns 500 error #924

Closed pbochynski closed 4 years ago

pbochynski commented 4 years ago

Description

It is not possible to successfully delete a service instance. Delete request returns operation id that is not persisted. The subsequent request returns the internal error (500).

Expected result

The delete request returns OK

Actual result

"Deprovision instanceID:" "468099BF-7A41-4704-9A19-EF659A92D076"
{"timestamp":"1583488852.922296286","source":"kyma-env-broker","message":"kyma-env-broker.deprovision.unknown-error","log_level":2,"data":{"correlation-id":"1edf3a54-b3cb-4838-b549-23773759a7d3","error":"instance not found","instance-id":"468099BF-7A41-4704-9A19-EF659A92D076","session":"77"}}
{"timestamp":"1583488852.922296286","source":"kyma-env-broker","message":"kyma-env-broker.deprovision.unknown-error","log_level":2,"data":{"correlation-id":"1edf3a54-b3cb-4838-b549-23773759a7d3","error":"instance not found","instance-id":"468099BF-7A41-4704-9A19-EF659A92D076","session":"77"}}
127.0.0.1 - - [06/Mar/2020:10:00:52 +0000] "DELETE /v2/service_instances/468099BF-7A41-4704-9A19-EF659A92D076?service_id=47c9dcbf-ff30-448e-ab36-d3bad66ba281&plan_id=4deee563-e5ec-4731-b9b1-53b42d855f0c&accepts_incomplete=true HTTP/1.1" 500 37

Steps to reproduce

Create the instance and delete it.

pbochynski commented 4 years ago

It still doesn't work in case provisioning failed or instance is already deleted. See example:

time="2020-04-01T10:13:23Z" level=info msg="Deprovisioning triggered, details: {PlanID:4deee563-e5ec-4731-b9b1-53b42d855f0c ServiceID:47c9dcbf-ff30-448e-ab36-d3bad66ba281 Force:false}" instanceID=468099BF-7A41-4704-9A19-EF659A92D076
{"timestamp":"1585736003.662887573","source":"kyma-env-broker","message":"kyma-env-broker.deprovision.instance-missing","log_level":2,"data":{"correlation-id":"f62bf91e-2f74-4af5-859f-1c207eb8e20e","error":"instance does not exist","instance-id":"468099BF-7A41-4704-9A19-EF659A92D076","session":"212"}}
127.0.0.1 - - [01/Apr/2020:10:13:23 +0000] "DELETE /oauth/v2/service_instances/468099BF-7A41-4704-9A19-EF659A92D076?service_id=47c9dcbf-ff30-448e-ab36-d3bad66ba281&plan_id=4deee563-e5ec-4731-b9b1-53b42d855f0c&accepts_incomplete=true HTTP/1.1" 410 3
time="2020-04-01T10:13:23Z" level=warning msg="instance does not exists" instanceID=468099BF-7A41-4704-9A19-EF659A92D076
{"timestamp":"1585736003.662887573","source":"kyma-env-broker","message":"kyma-env-broker.deprovision.instance-missing","log_level":2,"data":{"correlation-id":"f62bf91e-2f74-4af5-859f-1c207eb8e20e","error":"instance does not exist","instance-id":"468099BF-7A41-4704-9A19-EF659A92D076","session":"212"}}

The service should return ok if instance is missing.

piotrmiskiewicz commented 4 years ago

according to OSB API spec the response should be 410 (if the Service Instance does not exist): https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#deprovisioning

polskikiel commented 4 years ago

Will be fixed in #1116