kyma-bot
commented
3 months ago Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Closed triffer closed 3 months ago
kyma-bot
commented
3 months ago Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Description
Changes proposed in this pull request:
Add all relevant validation for rules from v1beta1 Istio handler including sidecar injection for v2alpha1
Update paths from v1beta1 validation to match with new v2alpha1 APIRule
Move tests from validation/v1beta1 package and validation/v1beta1/istio package to v2alpha1 package to verify same functionality
Don't test against exported functions in tests, to have a smaller scoping, especially since there is another PR that will change the behaviour of the exported Validate function.
Disable cache for v2alpha1 APIRule since this caused an issue with reconciling an APIRule that was recreated after deletion
Pre-Merge Checklist
[x] As a PR reviewer, verify code coverage and evaluate if it is acceptable.
Related issues